Skip to content

feat!(stackable-certs): Support adding SAN entries #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jun 25, 2025
Merged

feat!(stackable-certs): Support adding SAN entries #1057

merged 21 commits into from
Jun 25, 2025
+126 −32

Conversation

sbernauer
Copy link
Member

Description

As #1044 didn't move along, splitting the relevant change out to unblock CRD versioning.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Jun 23, 2025
NickLarsenNZ

This comment was marked as resolved.

Sign in to view

sbernauer and others added 3 commits June 24, 2025 09:20
@sbernauer @NickLarsenNZ
Update crates/stackable-certs/src/ca/mod.rs
67cba18 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@sbernauer @NickLarsenNZ
Update crates/stackable-certs/CHANGELOG.md
4dc617f 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@sbernauer @NickLarsenNZ
Update crates/stackable-certs/CHANGELOG.md
b5faf6d 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@sbernauer sbernauer requested a review from NickLarsenNZ June 24, 2025 07:26
NickLarsenNZ

This comment was marked as outdated.

Sign in to view

@sbernauer
Copy link
Member Author

Thanks for the review!

@sbernauer sbernauer enabled auto-merge June 25, 2025 07:01
@sbernauer sbernauer disabled auto-merge June 25, 2025 07:01
Techassi
Techassi requested changes Jun 25, 2025
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't take a close look at this, but I will soon.

Blocking it for now.

Techassi
Techassi requested changes Jun 25, 2025
View reviewed changes
@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 25, 2025
sbernauer and others added 3 commits June 25, 2025 12:47
@sbernauer @NickLarsenNZ
Update crates/stackable-certs/src/ca/mod.rs
ca488cd 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@sbernauer
lowercase error message
408c33f
@sbernauer
Airflow -> Product
98acd6c
@sbernauer sbernauer requested a review from Techassi June 25, 2025 10:56
@sbernauer sbernauer enabled auto-merge June 25, 2025 11:56
@sbernauer sbernauer requested review from Techassi and removed request for Techassi June 25, 2025 11:56
Techassi
Techassi requested changes Jun 25, 2025
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one final comment.

@sbernauer @Techassi
Update crates/stackable-certs/src/ca/mod.rs
76ea5b2 
Co-authored-by: Techassi <git@techassi.dev>
@sbernauer sbernauer requested a review from Techassi June 25, 2025 12:05
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Jun 25, 2025
@sbernauer sbernauer added this pull request to the merge queue Jun 25, 2025
Merged via the queue into main with commit 045a8cc Jun 25, 2025
8 checks passed
@sbernauer sbernauer deleted the feat/san-2 branch June 25, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ left review comments

@Techassi Techassi Techassi approved these changes

Assignees

@sbernauer sbernauer

Labels
None yet
Projects
Stackable Engineering
Status: Development: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbernauer @NickLarsenNZ @Techassi